Skip to content

166 constructor binding report #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

fabapp2
Copy link
Contributor

@fabapp2 fabapp2 commented Oct 31, 2022

Closes #490

Things to discuss or helps:

  • There is a test written that asserts positive case that is, a constructor binding annotation is used and we see a report we need one more assertion for cases where there is no constructor binding classes and we assert a relevant section is not rendered. This has to be carried over to all the tests pertaining to report generation that has been written.
  • ConstructorBinding detection is Naive as of now, we need to create new issue describing all the conditions and user advice that needs to be generated.

Its better to merge this PR first and then current PR

@fabapp2 fabapp2 closed this Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.0.0: report: 3.0.0-M2 Improved @ConstructorBinding Detection
2 participants